fix(cloudflare): Try/catch on non-configurable prototypes - #23132
Merged
Conversation
chargome
approved these changes
Aug 7, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+331
to
337
| try { | ||
| Object.defineProperty(prototype, methodName, { ...descriptor, value: wrapped }); | ||
| } catch {} | ||
|
|
||
| // Only the wrapper is marked, not the original method: `wrapMethodWithSentry` resolves | ||
| // through the same global map and must not resolve the original to this wrapper, | ||
| // which would recurse. |
Contributor
There was a problem hiding this comment.
Bug: The code repeatedly tries to instrument non-configurable methods on each new class instance because it doesn't mark them as "failed to wrap" after the first attempt.
Severity: LOW
Suggested Fix
To prevent redundant work, the original method should be marked as having had an instrumentation attempt, even if it fails. This could be achieved by marking the original descriptor.value within the catch block after Object.defineProperty throws, preventing getRpcMethodDescriptor from re-selecting it for wrapping on subsequent constructions.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: packages/cloudflare/src/durableobject.ts#L331-L337
Potential issue: When a class has a non-configurable method, the instrumentation logic
attempts to wrap it using `Object.defineProperty`. This fails as expected, but the
original method is not marked to prevent future wrapping attempts. Consequently, for
every new instance of the class, the system re-attempts the same failed wrapping
operation. This results in minor performance overhead due to the creation of a new
closure and a doomed `defineProperty` call on each construction. The application's
functionality is not affected, but it introduces redundant work.
Did we get this right? 👍 / 👎 to inform future reviews.
Contributor
size-limit report 📦
|
andreiborza
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed a comment here: #23057 (comment)